Skip to content

Update developer documentation: releases and git commits #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2020
Merged

Update developer documentation: releases and git commits #1444

merged 2 commits into from
Jun 1, 2020

Conversation

@catarak
Copy link
Member

@catarak catarak commented Jun 1, 2020

[#1421]

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

catarak added 2 commits June 1, 2020 15:31
@catarak
RE: #1421, Add documentation about creating a GitHub release after cr…
33b290d 
…eating a tag
@catarak
[#1421] Update git commit guide
01816d2 
Modify the git commit guide to be clearer, specifically asking to link
GitHub issues with every commit. Also update the pull request template
with the line "Fixes #issue-number" so that every PR will close an issue
when it is merged.
@catarak catarak merged commit 11511a8 into develop Jun 1, 2020
@catarak catarak deleted the release-notes branch June 1, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@catarak